Update plugin.py to enable asyncio debugging #140
Conversation
Changed plugin.py to enable debug on the event loop fixture. This allows any tasks that are not closed correctly to be logged in such a way that we can see which test they originate from, which is incredibly useful in testing large libraries where a test somewhere may not be awaiting something correctly or may be closing the event loop without terminating tasks correctly.
|
@nekokatt Maybe it should be possible to turn this off and on, debugging code permanently on could possibly annoy users. |
|
Arent these warnings almost always an indicator that your tests have issues that can affect how they operate, though? |
|
That is possible, I was reflecting over that it is an option on the loop and not the default behavior. Will this not also show warnings from other parts except the tests, like all asyncio code? |
|
How does this relate to setting the environment variable PYTHONASYNCIODEBUG = 1? |
|
Good point, it seems this can be achieved without change in pytest-asyncio by setting the environment variable in systems where it is wanted |
|
The PR should be closed I guess. |
3 participants
Changed plugin.py to enable debug on the event loop fixture.
This allows any tasks that are not closed correctly to be logged
in such a way that we can see which test they originate from,
which is incredibly useful in testing large libraries where a test
somewhere may not be awaiting something correctly or may be
closing the event loop without terminating tasks correctly.